feat: output-encode-only methods #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @stephenh can I solve the prettier error or is something CI related? |
|
@Frabat if you run |
|
@stephenh done! |
|
Erg, sorry for the flakey tests, I think we had several tests sharing the same port. I believe I've fixed it in: Can you rebase on top of that / on top of main? Thank you! |
|
@stephenh never mind! Rebased! |
|
Looks great! Thanks @Frabat ! |
stephenh
pushed a commit
that referenced
this pull request
Mar 8, 2023
# [1.141.0](v1.140.0...v1.141.0) (2023-03-08) ### Features * output-encode-only methods ([#787](#787)) ([3594410](3594410))
|
🎉 This PR is included in version 1.141.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by me in #773, I've changed the outputEncodeMethods to accept also "encode-only" and "decode-only" string values.
Since my use case also didn't need the creation methods, I've added a third option "encode-no-creation" that doesn't export that.
In theory, this could be included with the "encode-only" flag, since the creation method is used just by the encoder, but somebody might need it.